Wireshark-commits: [Wireshark-commits] master-1.10 8f61ce9: ncp2222: initialize buffer in build_exp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 25 Oct 2014 18:13:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f61ce9b8a4a038849af88328dfc3ed74c2591a6
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

8f61ce9 by Evan Huus (eapache@xxxxxxxxx):

    ncp2222: initialize buffer in build_expert_data
    
    We do a bunch of conditional logic to fill in the buffer, and then were checking
    strlen(buffer) to see if we'd actually filled it in or not, but if we hadn't
    then the buffer was garbage and strlen(buffer) was throwing valgrind warnings.
    Ensure this works as intended by setting the first byte of the buffer
    unconditionally at the beginning, so strlen(buffer) returns 0 as expected in
    that case.
    
    Bug: 10628
    Change-Id: I6f6c29fbbcb601b6ebccb3a4b312f0fa72c169ae
    Reviewed-on: https://code.wireshark.org/review/4926
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  d7174c0   tn5250: fix an endless loop, exit when offset is not incremented
    adds  8f61ce9   ncp2222: initialize buffer in build_expert_data


Summary of changes:
 epan/dissectors/packet-ncp2222.inc |    1 +
 1 file changed, 1 insertion(+)