Wireshark-commits: [Wireshark-commits] master a168c44: Remove (almost all) proto_tree_add_text call
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Oct 2014 19:14:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a168c44fc05210f84798c950f0271fe1afcbd462
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a168c44 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove (almost all) proto_tree_add_text calls in ISUP dissector.
    
    Change-Id: I57a01eacaa02e45c23bb4827ae982c897fb308ee
    Reviewed-on: https://code.wireshark.org/review/4592
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  a193302   NCP: switch to wmem memory and ensure that all fields are initialized
    adds  a168c44   Remove (almost all) proto_tree_add_text calls in ISUP dissector.


Summary of changes:
 asn1/camel/camel.cnf           |    4 +-
 asn1/inap/inap.cnf             |    2 +-
 epan/dissectors/packet-camel.c |    4 +-
 epan/dissectors/packet-inap.c  |    2 +-
 epan/dissectors/packet-isup.c  |  980 +++++++++++++++++++++-------------------
 epan/dissectors/packet-isup.h  |    6 +-
 6 files changed, 522 insertions(+), 476 deletions(-)