Wireshark · Ethereal-dev: Re: [Ethereal-dev] [Patch] MGCP cleanup/update

[Lars Roland <lars.roland@xxxxxxx>]

Martin Mathieson schrieb:
> I wanted to do a patch that was purely a cleanup, but some other things
> sneaked in.  I've tested it with all of the captures I have here, donations
> gratefully received.
>
> Martin
>
> This update includes:
> - re-indenting/formatting the file as it was tricky to follow
> - some code simplification and commenting (more to do)
> - losing some unnecessary includes (not needed under linux at least...)
> - show duplicate request and response fields in tree (previously hidden)
> - improved duplicate response detection
> - fix a couple of problems shown by fuzz testing

Checked in.

BTW, reviewing was a lot simpler after filtering out the reindentation. The 
patch was still big, but nearly all changes were shown line by line.

I prefer tabs instead of normal spaces for indentation. Does anyone have 
objections against changing this in packet-mgcp.[ch] .

Regards,
Lars