Hello Martin,
I used your patch and I noticed some differences between your reindentation and
the reindentation produced by my editor (jedit)
It looks like you have converted all tabs into 4 spaces in packet-mgcp.c, while
you are using tabs for indentation in packet-mgcp.h. I prefer tabs for indentation.
After reindenting your packet-mgcp.c with tabs using jedit again, I was able to
produce a diff showing only the differences of content. So I can start reviewing
it, now.
I'll propose following approach to make the next changes as easy as possible.
After reviewing your changes, I'll check in the patch you sent to the list with
your reindentation. Then you will sent your additional changes and I'll check
them in, too. With all your current changes checked in, I'll do my
reindentation, using tabs.
This should avoid unneccessary work for you and me.
Best regards,
Lars
Lars Roland schrieb:
Hello Martin,
I'll try something different. I'll make a diff between my reindented
packet-mgcp.c and your patched packet-mgcp.c . I hope this filters out
the reindentation, making it easier to review the changes.
Regards,
Lars
Martin Mathieson (NTL) schrieb:
Lars,
This will be a pain, but if its the only way lets do what you suggest.
It will result in a smaller patch from me, but still quite big... (plus I
have some new stuff in my current file queued up).
Regards,
Martin
----- Original Message -----
From: "Lars Roland" <lars.roland@xxxxxxx>
To: "Ethereal development" <ethereal-dev@xxxxxxxxxxxx>
Sent: Sunday, April 24, 2005 9:19 PM
Subject: Re: [Ethereal-dev] [Patch] MGCP cleanup/update
Martin Mathieson schrieb:
I wanted to do a patch that was purely a cleanup, but some other things
sneaked in. I've tested it with all of the captures I have here,
donations
gratefully received.
Mixed patch (cleanup and new features) are not a good idea. It is nearly
unreadable.
Martin
This update includes:
- re-indenting/formatting the file as it was tricky to follow
- some code simplification and commenting (more to do)
- losing some unnecessary includes (not needed under linux at least...)
- show duplicate request and response fields in tree (previously
hidden)
- improved duplicate response detection
- fix a couple of problems shown by fuzz testing
Still to do:
- I'd like to change the way the 'Display raw text for MGCP message' is
done, to make it more like SIP. All of the 'my_proto...' function
pointer
stuff clutters the code and isn't done throughout anyway
- Make it not a plugin anymore
How about separating work for this. I do the reindentation and you redo
the
patch, based on my reindentation. This should significantly decrease the
size of
the patch.
I hope this won't be too much work for you.
If you agree, I will check in the reindentation of packet-mgcp.c.
Regards,
Lars
_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev
