Wireshark · Ethereal-dev: Re: [Ethereal-dev] [Patch] MGCP cleanup/update

["Martin Mathieson (NTL)" <martin.mathieson@xxxxxxxxxxxx>]

> BTW, reviewing was a lot simpler after filtering out the reindentation.
The
> patch was still big, but nearly all changes were shown line by line.
>
> I prefer tabs instead of normal spaces for indentation. Does anyone have
> objections against changing this in packet-mgcp.[ch] .
>
> Regards,
> Lars

Thanks for taking care of this, Lars.

I do prefer tabs (like you, I use jEdit which makes it easy to adapt to or
change the current indentation settings) in principle, but in practice I
often find using spaces is easier to maintain, e.g. in the following

        call_function(param1,
                            param2);

if you want param1 and param2 to line up, then for the second line you
should only use as many tabs as the first line has, then use spaces after
that.  Otherwise, if someone has a different tab width from you they won't
be aligned as you intended.  It *will* get misaligned, and when people see a
messy file it quickly gets even messier.

This rant aside, I'd have no objection to your re-indenting with tabs
(before or after my next patch - I can 'diff -b' and re-patch with my
changes if necessary).

Best regards,
Martin