Ethereal-dev: [Ethereal-dev] [Patch] MGCP cleanup/update

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Martin Mathieson" <martin.mathieson@xxxxxxxxxxxx>
Date: Sat, 23 Apr 2005 12:45:29 +0100
I wanted to do a patch that was purely a cleanup, but some other things
sneaked in.  I've tested it with all of the captures I have here, donations
gratefully received.

Martin

This update includes:
- re-indenting/formatting the file as it was tricky to follow
- some code simplification and commenting (more to do)
- losing some unnecessary includes (not needed under linux at least...)
- show duplicate request and response fields in tree (previously hidden)
- improved duplicate response detection
- fix a couple of problems shown by fuzz testing

Still to do:
- I'd like to change the way the 'Display raw text for MGCP message' is
done, to make it more like SIP.  All of the 'my_proto...' function pointer
stuff clutters the code and isn't done throughout anyway
- Make it not a plugin anymore

Attachment: packet-mgcp.h.diff
Description: Binary data

Attachment: packet-mgcp.c.diff
Description: Binary data