Ethereal-dev: Re: [Ethereal-dev] First version of LSA pipe dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Ronnie Sahlberg" <sahlberg@xxxxxxxxxxxxxxxx>
Date: Wed, 19 Dec 2001 09:14:54 +1100
Hi Tim, Hi List

In your LSA dissector I have the following suggestions:

1,  prs_SECURITY_DESCRIPTOR() this one is implemented in packet-smb.c and is
called
dissect_nt_sec_desc() I think one of them should be removed since both are
supposed to dissect
'the same structure. Make prs_SECURITY_DESCRIPTOR just call
dissect_nt_sec_desc() instead?

2, prs_SID() this one is implemented in packet-smb.c as well and there it is
called
dissect_nt_sid(). I think one of them should be removed since both are
supposed to dissect the same structure.
Remove content of prs_SID() and make it just call dissect_nt_SID() instead?

3, placing. prs_SECURITY_DESCRIPTOR, prs_SID, prs_UNISTR and friends are not
local to LSA but will
be used by a lot of other dcerpc dissectors as well.
Perhaps one should move them out of LSA and into dcerpc-misc.c or something?
so that they are available to
other future dissectors as well.

4, naming: perhaps the prs_ functions should be changed so they maps easier
to what samba calls the structures.
I.e. prs_SEC_DESC   instead of prs_SECURITY_DESCRIPTOR, prs_UNISTR2()
instead of prs_UNISTR()?

Apart from that, it rocks.

best regards
  ronnie sahlberg