Ethereal-dev: Re: [Ethereal-dev] First version of LSA pipe dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 16 Dec 2001 12:19:31 -0800
On Sun, Dec 16, 2001 at 09:58:55PM +1100, Tim Potter wrote:
> Hi again.  I am proud to post the first version of the LSA pipe 
> dissector for Ethereal's DCERPC over SMB support.

Checked in (with "Makefile.nmake" updated, as well as "Makefile.am").

Note that you should make sure that no allocated data structures (such
as the ASCII strings allocated for Unicode strings) can be leaked if any
"proto_tree_add_XXX" calls throw an exception - either make sure no
exception is thrown before the data structures are freed, or use
"CLEANUP_PUSH()" and "CLEANUP_CALL_AND_POP" calls; see the GIOP
dissector for examples.

Also, I think you're the one who sent me an "lsa.cap" file containing
some LSA traffic, for testing; if so, note that frames 18, 22, and 34
report "Malformed Frame" errors - frame 18 has, in the NAME_AND_SID
header, a string header with a length of 47748 and a size of 12.