Ethereal-dev: Re: [Ethereal-dev] First version of LSA pipe dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Motonori Shindo <mshindo@xxxxxxxxxxx>
Date: Mon, 17 Dec 2001 09:05:29 +0900 (JST)
Hi,

From: Guy Harris <gharris@xxxxxxxxx>
Subject: Re: [Ethereal-dev] First version of LSA pipe dissector
Date: Sun, 16 Dec 2001 12:19:31 -0800

> On Sun, Dec 16, 2001 at 09:58:55PM +1100, Tim Potter wrote:
> > Hi again.  I am proud to post the first version of the LSA pipe 
> > dissector for Ethereal's DCERPC over SMB support.
> 
> Checked in (with "Makefile.nmake" updated, as well as "Makefile.am").

MSVC++ doesn't like the goto statement in this code for some
reason. A patch enclosed.

Regards,

=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=
 +----+----+     
 |.. .|    |     Motonori Shindo
 |_~__|    |     
 | .. |~~_~|     Sr. Systems Engineer
 | .  |    |     CoSine Communications Inc.
 +----+----+     
 C o S i n e     e-mail:  mshindo@xxxxxxxxxxxxx 
Communications
=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=



Index: packet-dcerpc-lsa.c
===================================================================
RCS file: /cvsroot/ethereal/packet-dcerpc-lsa.c,v
retrieving revision 1.3
diff -u -r1.3 packet-dcerpc-lsa.c
--- packet-dcerpc-lsa.c	2001/12/16 20:17:10	1.3
+++ packet-dcerpc-lsa.c	2001/12/17 00:01:07
@@ -721,9 +721,8 @@
 			offset = prs_DOM_RID(tvb, offset, pinfo, subtree, 
 					     PARSE_BUFFERS, ptr_list);
 		}
-done:
 	}
-
+done:
 	return offset;
 }
 
@@ -789,9 +788,8 @@
 			offset = prs_NAME_AND_SID(tvb, offset, pinfo, subtree,
 						  PARSE_BUFFERS, ptr_list);
 		}
-	done:
 	}
-
+done:
 	return offset;
 }
 
@@ -969,9 +967,8 @@
 			if (prs_pop_ptr(ptr_list, "SID"))
 				offset = prs_SID(tvb, offset, pinfo, subtree);
 		}
-	done:
 	}
-
+done:
 	return offset;
 }
 
@@ -1060,9 +1057,8 @@
 			offset = prs_ACCOUNT_NAME(tvb, offset, pinfo, subtree, 
 						  PARSE_BUFFERS, ptr_list);
 		}
-	done:
 	}
-
+done:
 	return offset;
 }
 
This message has been 'sanitized'.  This means that potentially
dangerous content has been rewritten or removed.  The following
log describes which actions were taken.

Sanitizer (start="1008549511"):
  Replaced MIME boundary: >>--Next_Part--<<
                    with: >>MIMEStream=_0+266289_29889243123768_5750033259<<
  Writer (pos="1237"):
    Total modifications so far: 1

  Part (pos="1283"):
    SanitizeFile (filename="unnamed.txt", mimetype="Text/Plain"):
      Match (rule="2"):
        Enforced policy: accept

  Part (pos="2246"):
    SanitizeFile (filename="dcerpc-lsa.diff", mimetype="Text/Plain"):
      Match (rule="default"):
        Enforced policy: accept


Anomy 0.0.0 : Sanitizer.pm
$Id: Sanitizer.pm,v 1.32 2001/10/11 19:27:15 bre Exp $