Wireshark-commits: [Wireshark-commits] master c8e24f5: RTPS: DomainId incorrectly dissected when us
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2020 09:35:32 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8e24f5c55cb37b9a311e5226923d291892de892
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c8e24f5 by Ismael Mendez Matamoros (ismael@xxxxxxx):

    RTPS: DomainId incorrectly dissected when using TCP
    
    Domain ID in non participant discovery packets is deduced from the port.
    This is valid only when using UDP. If using TCP that values must be
    taken from the discovery or otherwise mark it as unknown.
    
    Change-Id: I8fe64f5f67d86412edefdccdca8ded63193f6e14
    Reviewed-on: https://code.wireshark.org/review/38003
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fd9923c   USB HID: fail to parse the rdesc if it has mismatched report ID usage
     add  c8e24f5   RTPS: DomainId incorrectly dissected when using TCP


Summary of changes:
 epan/dissectors/packet-rtps.c | 82 +++++++++++++++++++++++++++++++++++++------
 1 file changed, 72 insertions(+), 10 deletions(-)