Wireshark-commits: [Wireshark-commits] master 4e59557: PROFINET: DHCP suboption undefined bytes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2020 10:46:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4e595577f3dc2cd673ae6a06cec6ecc086ba8975
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4e59557 by Basak Kalfa (basakkalfa@xxxxxxxxx):

    PROFINET: DHCP suboption undefined bytes
    
    There are undefined bytes which must be included in DHCP
    suboption block according to DCP Block Length. In other
    words, there are still bytes after dissection of defined
    parameters finish but DCP block length does not finish.
    In order to solve the problem, these bytes are included in
    DHCP suboption block and marked Undefined. The byte number
    can be 1, so bytes word in pn_user_data is changed to byte.
    
    Change-Id: I2be23b41a9827f9c2159b97a05658ddf557865cf
    Reviewed-on: https://code.wireshark.org/review/38203
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    

Actions performed:

    from  c8e24f5   RTPS: DomainId incorrectly dissected when using TCP
     add  4e59557   PROFINET: DHCP suboption undefined bytes


Summary of changes:
 plugins/epan/profinet/packet-pn-dcp.c | 7 +++++++
 plugins/epan/profinet/packet-pn.c     | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)