Wireshark-commits: [Wireshark-commits] master fd9923c: USB HID: fail to parse the rdesc if it has m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 20 Aug 2020 08:16:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd9923cb764eaca65caaef82672069823e757825
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

fd9923c by Filipe Laíns (lains@xxxxxxxxxxxxx):

    USB HID: fail to parse the rdesc if it has mismatched report ID usage
    
    If one field uses a report ID, all other should too. Otherwise we don't
    know if the first byte is a report ID or a data value.
    
    Change-Id: I84f5cde3f08c26d904d7c5f66e8d622b820b3f6c
    Signed-off-by: Filipe Laíns <lains@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37781
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bef04c2   USB HID: separate HID items into input and output
     add  fd9923c   USB HID: fail to parse the rdesc if it has mismatched report ID usage


Summary of changes:
 epan/dissectors/packet-usb-hid.c | 6 ++++++
 1 file changed, 6 insertions(+)