Wireshark-commits: [Wireshark-commits] master ba4066f: dicom: fix exporting objects with tshark
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2020 09:42:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba4066f470d6a55c13493c3b4b70a8df7ef1533d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ba4066f by John Thacker (johnthacker@xxxxxxxxx):

    dicom: fix exporting objects with tshark
    
    The names for files extracted from data PDVs depend on information in the tags.
    Need to read the tags for data PDVs if the Export Objects tap has a listener
    even if there isn't a tree (so that tshark works) and need to send data to
    Export Objects only after reading the tags (so that it works on the first pass).
    This makes the tshark single pass behavior match wireshark GUI behavior.
    
    Bug: 16771
    Change-Id: I6cfa792e7b86f205290ff92c9f5e09fd94a25f9f
    Reviewed-on: https://code.wireshark.org/review/38164
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  42cac8d   check_typed_item_calls.py:  add optional checks for labels and bitmask.
     add  ba4066f   dicom: fix exporting objects with tshark


Summary of changes:
 epan/dissectors/packet-dcm.c | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)