Wireshark-commits: [Wireshark-commits] master 42cac8d: check_typed_item_calls.py: add optional chec
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2020 05:50:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=42cac8dcfd9d98791e0aecfc69fc609478e5f79b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

42cac8d by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    check_typed_item_calls.py:  add optional checks for labels and bitmask.
    
    Most of the detected non-contiguous mask bitmasks seem to be valid - they often
    represent multiple unassigned/reserved bits that have been conflated into
    one hf item.
    
    A set of exceptions has been added to the script - a couple of genuine
    buts will be addressed presently in a separate commit.
    
    Change-Id: I87fcf6ee532819097c2daf20b4b1338abb4402d8
    Reviewed-on: https://code.wireshark.org/review/38103
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d97aedb   Fix a couple of item bitmasks where bit positions were ommitted in error.
     add  42cac8d   check_typed_item_calls.py:  add optional checks for labels and bitmask.


Summary of changes:
 tools/check_typed_item_calls.py | 135 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 125 insertions(+), 10 deletions(-)