Wireshark-commits: [Wireshark-commits] master-3.2 172b25f: dicom: fix exporting objects with tshark
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=172b25fa448512479a836687a311060fa3b4c12e
Submitter: "Jaap Keuter <jaap.keuter@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark
Commits:
172b25f by John Thacker (johnthacker@xxxxxxxxx):
dicom: fix exporting objects with tshark
The names for files extracted from data PDVs depend on information in the tags.
Need to read the tags for data PDVs if the Export Objects tap has a listener
even if there isn't a tree (so that tshark works) and need to send data to
Export Objects only after reading the tags (so that it works on the first pass).
This makes the tshark single pass behavior match wireshark GUI behavior.
Bug: 16771
Change-Id: I6cfa792e7b86f205290ff92c9f5e09fd94a25f9f
Reviewed-on: https://code.wireshark.org/review/38164
Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/38165
Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Reviewed-by: John Thacker <johnthacker@xxxxxxxxx>
Actions performed:
from 1b74b64 Check that at least one token exists to consider the JSON as valid
add 172b25f dicom: fix exporting objects with tshark
Summary of changes:
epan/dissectors/packet-dcm.c | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)