Wireshark · Wireshark-commits: [Wireshark-commits] master 5df5f8e: lanforge: clean up the dissector a bit

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5df5f8efe33c46d575b4991a4cc7c17526767578
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5df5f8e by Martin Kaiser (wireshark@xxxxxxxxx):

    lanforge: clean up the dissector a bit
    
    Use proto_tree_add_item() for the timestamp, there's no need to extract
    the time manually.
    
    Remove the unnecessary if (tree) check.
    
    Call proto_tree_add_item_ret_uint() to read the value and add it to the
    tree in one go.
    
    Change-Id: Ibce3a5c83c260e46c4bd6ebf957e300fd345ed8a
    Reviewed-on: https://code.wireshark.org/review/36765
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  55b8b56   mqtt: Improve message decoding when using v5.0
     add  5df5f8e   lanforge: clean up the dissector a bit


Summary of changes:
 epan/dissectors/packet-lanforge.c | 87 +++++++++++++++++----------------------
 1 file changed, 37 insertions(+), 50 deletions(-)