Wireshark-commits: [Wireshark-commits] master 55b8b56: mqtt: Improve message decoding when using v5
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Apr 2020 16:23:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55b8b5627c3ec7dadbffb5caca09b76d26249957
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

55b8b56 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    mqtt: Improve message decoding when using v5.0
    
    Use content-type property to decode message.
    
    Lookup Topic using topic-alias property mapping from the first Publish
    message if this is used by the sender. Add an expert info note when
    a lookup fails.
    
    MQTT-4.7.3-1 defines that all Topic Names and Topic Filters MUST be
    at least one character long. Add an expert info warning for this.
    
    Change-Id: I5b27a72462a7c80b200ec065e5aed167cf36a3a8
    Reviewed-on: https://code.wireshark.org/review/36748
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bd70114   SIP: Differentiate the Display Info items
     add  55b8b56   mqtt: Improve message decoding when using v5.0


Summary of changes:
 epan/dissectors/packet-mqtt.c | 173 ++++++++++++++++++++++++++++++++++--------
 1 file changed, 142 insertions(+), 31 deletions(-)