Wireshark-commits: [Wireshark-commits] master ac97bca: lanforge: timestamp and len field are not ge
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Apr 2020 18:52:58 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ac97bca5921812a734525bb9bfb284633ca792c4
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ac97bca by Martin Kaiser (wireshark@xxxxxxxxx):

    lanforge: timestamp and len field are not generated
    
    A generated item is not derived from the bytes in the packet.
    
    The components of the length field and the timestamp are fields in the
    packet. They should not be marked as generated.
    
    Change-Id: Ic2e74f7db50b2ea65bc0e48883e6562992114296
    Reviewed-on: https://code.wireshark.org/review/36766
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  5df5f8e   lanforge: clean up the dissector a bit
     add  ac97bca   lanforge: timestamp and len field are not generated


Summary of changes:
 epan/dissectors/packet-lanforge.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)