Wireshark-commits: [Wireshark-commits] master bd70114: SIP: Differentiate the Display Info items
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Apr 2020 16:21:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd701147dfe9bfb73c92ff25ac3f4c67b3fe5012
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

bd70114 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    SIP: Differentiate the Display Info items
    
    Currently every URI that carries display information has that presented
    as the same field. This makes specific filtering difficult.
    This change introduces seperate fields for every URI type, while
    preserving the common display info field as hidden item.
    A display field has been introduced for every URI handled, whether or
    not the field is described in an RFC. Practice learns that it may be
    done anyway.
    
    Bug: 16488
    Change-Id: I15bf10e3fbdcce581a62182c205976a751c98c69
    Reviewed-on: https://code.wireshark.org/review/36773
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1f80297   Bluetooth: Handle reserved bits in LE channel map
     add  bd70114   SIP: Differentiate the Display Info items


Summary of changes:
 epan/dissectors/packet-sip.c | 91 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 85 insertions(+), 6 deletions(-)