Wireshark-commits: [Wireshark-commits] master b2ee7a2: WireGuard: fix null pointer crash
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2ee7a2876c26b71f50cd0808c89af6a8483f007
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
b2ee7a2 by Peter Wu (peter@xxxxxxxxxxxxx):
WireGuard: fix null pointer crash
It was assumed that the WireGuard dissector is always called on the
first pass before the second pass. That might not be the case when the
heuristics dissector sets a conversation dissector later in the stream.
Be prepared to handle this case. Do not simply abort, the previous
packets may be valid data messages.
Bug: 16394
Change-Id: Id5bf38c07f4d1bffd4b372e92d9a8784e094829a
Reviewed-on: https://code.wireshark.org/review/36148
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from c268e9b Use "must" instead of "should" to avoid ambiguity.
add b2ee7a2 WireGuard: fix null pointer crash
Summary of changes:
epan/dissectors/packet-wireguard.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)