Wireshark-commits: [Wireshark-commits] master-2.6 4f00a46: Use "must" instead of "should" to avoid
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f00a466cdb27925f7f9d43f65bfd5ff6022c51a
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark
Commits:
4f00a46 by Guy Harris (guy@xxxxxxxxxxxx):
Use "must" instead of "should" to avoid ambiguity.
As I said in
https://ask.wireshark.org/question/10361/how-to-properly-use-heuristic-dissector-for-tcp/?answer=10363#post-id-10363
"Should" has multiple meanings; there's "Used to indicate obligation,
duty, or correctness, typically when criticizing someone's actions.", as
in "I think we should trust our people more", and there's "Used to
indicate what is probable.", as in "the bus should arrive in a few
minutes". You're reading it in the latter sense; it was intended in the
former sense.
That sentence should probably be changed to "Wireshark must be then set
up..." to avoid the ambiguity.
Make it so (over half a year later, sigh), and change another case where
"should" is meant in the first sense while we're at it.
Change-Id: I90198d1616619c75802deeeb703ceee0c8bac1bf
Reviewed-on: https://code.wireshark.org/review/36155
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
(cherry picked from commit c268e9b0d563cfd248fae611c06e39430e1bad6c)
Reviewed-on: https://code.wireshark.org/review/36158
Actions performed:
from 3e81637 [Automatic update for 2020-02-16]
add 4f00a46 Use "must" instead of "should" to avoid ambiguity.
Summary of changes:
doc/README.heuristic | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
