Wireshark-commits: [Wireshark-commits] master a2530f7: WireGuard: ignore messages with invalid leng
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 23 Feb 2020 06:09:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a2530f740d67d41908e84434bb5ec99480c2ac2e
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a2530f7 by Peter Wu (peter@xxxxxxxxxxxxx):

    WireGuard: ignore messages with invalid lengths
    
    A UDP payload of 543 bytes can never be a valid Handshake Initiation
    message for example. Reject such messages to avoid user confusion.
    
    Bug: 16394
    Change-Id: Ia40ae24f8ff8abaf2bead54cbf091db907b66373
    Reviewed-on: https://code.wireshark.org/review/36149
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  b2ee7a2   WireGuard: fix null pointer crash
     add  a2530f7   WireGuard: ignore messages with invalid lengths


Summary of changes:
 epan/dissectors/packet-wireguard.c | 46 +++++++++++++++++++++-----------------
 1 file changed, 25 insertions(+), 21 deletions(-)