Wireshark-commits: [Wireshark-commits] master-3.0 021df20: wsutil: Read stderr and stdout data asyn
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 16 Apr 2019 10:52:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=021df2070c7867296c9b7689f8ae9b4ffe0bbc9f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

021df20 by Tomasz Moń (desowin@xxxxxxxxx):

    wsutil: Read stderr and stdout data asynchronously
    
    This significantly reduces the initialization time when system is using
    small pipe buffers. No time is lost on periodic process status checks as
    WaitForMultipleObjects() returns when the stdout/stderr data was read
    and/or when process finishes.
    
    Bug: 14657
    Change-Id: I61fabf986577db7102a3136df83d2d92c7156727
    Reviewed-on: https://code.wireshark.org/review/32773
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 9d7d4c015c0e531e6090aebaa3fcc0ba1d6e12df)
    Reviewed-on: https://code.wireshark.org/review/32870
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  0783ab0   Qt: Do not pass empty values for extcap boolflags
     add  021df20   wsutil: Read stderr and stdout data asynchronously


Summary of changes:
 wsutil/ws_pipe.c | 218 +++++++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 178 insertions(+), 40 deletions(-)