Wireshark-commits: [Wireshark-commits] master-3.0 27e5c64: Qt: Display checkboxes for extcap multic
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=27e5c641525f78ed0788f6db55322255fe51a7f0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
27e5c64 by Tomasz Moń (desowin@xxxxxxxxx):
Qt: Display checkboxes for extcap multicheck
Multicheck was introduced to make it easy to configure USBPcap to
capture only from selected devices instead of the whole Root Hub.
In GTK+ interface the multicheck enabled options featured a checkbox
next to the item entry. Displaying the checkboxes made it intuitive to
the user that the items can be checked/unchecked.
During the GTK+ to Qt transition, the checkbox idea got lost. The GTK+
interface up to its very last days did show the checkboxes.
While it is possible to select the individual devices in Qt UI and
actually have USBPcap to capture only on selected devices, it is really
unintuitive and the user simply has to know how the multicheck is
implemented to take advantage of it.
This change brings the multicheck checkboxes to Qt UI.
Ping-Bug: 13355
Change-Id: Ia677ff2222c46b9816b8dca4c47e93c72cee834f
Reviewed-on: https://code.wireshark.org/review/32813
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 458fa7b27412db389dba376a26c5e8b3184b1814)
Reviewed-on: https://code.wireshark.org/review/32872
Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
Actions performed:
from 021df20 wsutil: Read stderr and stdout data asynchronously
add 27e5c64 Qt: Display checkboxes for extcap multicheck
Summary of changes:
ui/qt/extcap_argument_multiselect.cpp | 38 +++++++++++++++++------------------
ui/qt/extcap_argument_multiselect.h | 4 ++--
2 files changed, 21 insertions(+), 21 deletions(-)
