Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 0783ab0: Qt: Do not pass empty values for extcap boolflags

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0783ab0d1e02dcb5bfffdd75008039b8c52cb8dc
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

0783ab0 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Do not pass empty values for extcap boolflags
    
    For extcap boolean flags inserted into arguments hash table, the key should
    be the "call" option and value should be NULL.
    extcap_add_arg_and_remove_cb() takes care of NULL values by simply
    omitting them from generated argument list.
    
    ws_pipe_spawn_async() appends arguments until either:
      * argument string is NULL
      * argument string points directly to NULL terminator (empty string)
    
    This bug resulted in extcap arguments being "cut off" after the first
    "boolflag" present in the commandline arugments. Because arugments hash
    table is unordered the actual commandline passed to extcap depended on
    the order in which options were changed in extcap configuration dialog.
    
    Bug: 15586
    Change-Id: I00f136d3b627064cbfb539b3429aa5e4aef319e1
    Reviewed-on: https://code.wireshark.org/review/32848
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 75a6897b0f574df6c8d983e45f2eecb014a4bdc1)
    Reviewed-on: https://code.wireshark.org/review/32871
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    

Actions performed:

    from  908671c   Revert "CRMF: Handle 64 bit serialNumber"
     add  0783ab0   Qt: Do not pass empty values for extcap boolflags


Summary of changes:
 ui/qt/extcap_options_dialog.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)