Wireshark-commits: [Wireshark-commits] master 5b85613: GSM_MAP: adding dissector for sendParameters
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Jul 2015 07:27:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b856134f66f96d1073dd95df9c213cc41869706
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5b85613 by Luca Melette (luca@xxxxxxxxx):

    GSM_MAP: adding dissector for sendParameters (MAPv1)
    
    The current ASN.1 description of MAP (3GPP 29.002) is missing this operation.
    I recovered the needed code from an old MAP description (ets_300599e01p) and
    integrated the missing parts into the asn tree and C template file (via asn2wrs).
    
    Change-Id: Ibe05e6a99f3f95ac66740b5d319a7200fdb3e54b
    Reviewed-on: https://code.wireshark.org/review/9594
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b467f1c   SMB2: only move ssi for request if request is really complete
    adds  5b85613   GSM_MAP: adding dissector for sendParameters (MAPv1)


Summary of changes:
 asn1/gsm_map/GSMMAP.asn                |   49 +++++-
 asn1/gsm_map/MAP-MS-DataTypes.asn      |    5 +-
 asn1/gsm_map/gsm_map.cnf               |    2 -
 asn1/gsm_map/packet-gsm_map-template.c |   11 +-
 epan/dissectors/packet-gsm_map.c       |  287 +++++++++++++++++++++++++-------
 5 files changed, 279 insertions(+), 75 deletions(-)