Wireshark-commits: [Wireshark-commits] master a03a43b: Capture file retapping fixups.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 29 Jul 2015 20:45:57 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a03a43bd320ceeaae9f2dfa2f15213dced579d17
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a03a43b by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Capture file retapping fixups.
    
    Add CaptureFile::delayedRetapPackets, which starts retapping after the
    current batch of UI event are processed. Call it in the constructors of
    various dialogs so that they are shown before tapping starts.
    
    This *might* fix a crash found when following large streams from the
    Conversations dialog.
    
    Change-Id: If1b87491621ab7efcc0519f95891d34dcd9d18c1
    Reviewed-on: https://code.wireshark.org/review/9818
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  5b85613   GSM_MAP: adding dissector for sendParameters (MAPv1)
    adds  a03a43b   Capture file retapping fixups.


Summary of changes:
 ui/qt/capture_file.cpp                 |    6 ++++++
 ui/qt/capture_file.h                   |   21 ++++++++++++++++-----
 ui/qt/conversation_dialog.cpp          |    4 ++--
 ui/qt/endpoint_dialog.cpp              |    2 +-
 ui/qt/main_window_slots.cpp            |    2 +-
 ui/qt/response_time_delay_dialog.cpp   |    2 +-
 ui/qt/service_response_time_dialog.cpp |    2 +-
 ui/qt/simple_statistics_dialog.cpp     |    2 +-
 ui/qt/voip_calls_dialog.cpp            |    2 +-
 9 files changed, 30 insertions(+), 13 deletions(-)