Wireshark-commits: [Wireshark-commits] master b467f1c: SMB2: only move ssi for request if request i
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 28 Jul 2015 22:32:41 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b467f1c211eb34dba70842a9262827b1e7925cfc
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b467f1c by Noel Power (noel.power@xxxxxxxx):

    SMB2: only move ssi for request if request is really complete
    
    MS-SMB2 section '3.2.5.1.5 Handling Asynchronous Responses' states
    
      "If SMB2_FLAGS_ASYNC_COMMAND is set in the Flags field of the SMB2
       header and Status is not STATUS_PENDING, this is a final response
       to a request which was processed by the server asynchronously"
    
    This patch delays moving ssi information for a processed request
    to the matched hashmap until the request is actually completed.
    Without this patch the ssi information for the *final* matching
    message id response will not be available (on first pass) so a
    subdissector (e.g. MS-WSP) will not have the ssi information available
    to it. After this patch the ssi infomation will remain in the 'unmatched'
    hashmap until the 'final' response for the request is seen. While
    processing the 'final' matching response the ssi will be moved to
    the matched hashmap.
    
    Change-Id: Id501179ecb4f967a34c82b07d34dcdcd92537dc3
    Bug: 11402
    Signed-off-by: Noel Power <noel.power@xxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/9805
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  254dd6b   MSWSP: Enhance dissector
    adds  b467f1c   SMB2: only move ssi for request if request is really complete


Summary of changes:
 epan/dissectors/packet-smb2.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)