Ethereal-dev: [Ethereal-dev] Re: DCCP: new dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Tue, 20 Sep 2005 15:42:55 -0400
checked in

On 9/20/05, Francesco Fondelli <francesco.fondelli@xxxxxxxxx> wrote:
> On 9/20/05, Gerald Combs <gerald@xxxxxxxxxxxx> wrote:
> > ronnie sahlberg wrote:
> > > Could do the following changes :
> > >
> > > 1,  there are many sprintf  that is just building a string to put on
> the
> 
> Done. I used proto_item_append_text(). You find the new .c file attached.
> 
> > > 2, add a protocol page to the wiki
> > > 3, upload the example captures to the wiki
> 
> no time now sorry, I'll do it tomorrow
> 
> > 4, in dissect_options(), option_len defaults to 0.  Could this result in
> > an infinite loop later on?
> 
> Hemm, I have been watching that loop for a while and I think is ok.
> option_len at each iteration is something > 2 or ==1 else [malformed]
> exit loop and return.
> 
> Ciao
> FF
> 
>