Ethereal-dev: Re: [Ethereal-dev] DCCP: new dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: ronnie sahlberg <ronniesahlberg@xxxxxxxxx>
Date: Wed, 21 Sep 2005 03:10:41 +1000
Could do the following changes :

1,  there are many sprintf  that is just building a string to put on the proto item lines.
maybe this can be changed to eliminate the string building alltogether and use
proto_item_append_...() instead?
or at least replace them with g_snprintf()

2, add a protocol page to the wiki

3, upload the example captures to the wiki



On 9/21/05, Francesco Fondelli <francesco.fondelli@xxxxxxxxx> wrote:
Joerg Mayer wrote:
> On Tue, Sep 20, 2005 at 03:56:16PM +0200, Francesco Fondelli wrote:
>
>>I have tested this dissector for a while and, as far as I now, it is stable.
>
>
> Checked in.

thank you

> One question though: Why did you name the files packet-dcp insteada
> of packet-dccp?

Unfortunately protoabbrev "dccp" is already in use by packet-dccp.c dissector :-(
... and "dcp" was the former name of datagram [congestion] control protocol a couple of
years ago.

>  ciao
>      Joerg

Ciao
FF




_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev