Ethereal-dev: Re: [Ethereal-dev] DCCP: new dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxx>
Date: Tue, 20 Sep 2005 12:37:45 -0500
ronnie sahlberg wrote:
> Could do the following changes :
> 
> 1,  there are many sprintf  that is just building a string to put on the
> proto item lines.
> maybe this can be changed to eliminate the string building alltogether
> and use
> proto_item_append_...() instead?
> or at least replace them with g_snprintf()
> 
> 2, add a protocol page to the wiki
> 
> 3, upload the example captures to the wiki

4, in dissect_options(), option_len defaults to 0.  Could this result in
an infinite loop later on?