Ethereal-dev: RE: [Ethereal-dev] The new save as dialog box looks good, but ...
| From: Richard Sharpe
|
| On Tue, 30 Dec 2003, Biot Olivier wrote:
|
| > | OK, it really looks like the "... but displayed packets
| only" really
| > | applies to a number of the choices above, so it probably
| should be:
| > |
| > | [] Save only displayed packets
| > |
| > | However, since people really expect the displayed packets to
| > | be saved, and
| > | might not be aware that there are filtered packets that are
| > | in the capture
| > | but not displayed, perhaps we should say:
| > |
| > | [] Also save any packets not currently displayed
| >
| > To me this is confusing in the way that I (along with many
| other Ethereal
| > users in their novice time) believed that "displayed" meant
| "visible in the
| > UI" hence limiting the scope to the number of visible
| GtkCList rows in the
| > "packet view" widget, which it isn't. I think it is more
| intuitive to talk
| > about a filter always being used by default instead of packets being
| > displayed or not as the latter allows more than one
| interpretation. But then
| > we probably should take more time in introducing the
| filters in the manual
| > :)
|
| Hmmm, that is a valid criticism ...
I'd like to contribute on this. Expect some input in the coming weeks :)
| in which case, I guess it should be
|
| [] Also save all packets currently filtered out
|
| and make sure that the tooltip gives enough information so
| that the phrase is understandable.
That's exactly what it should be! I'll try to reformulate the tooltip:
"By default, the range will be applied to the packets currently displayed
(i.e., that match the current display filter). When ticking this option, the
selection will apply to all captured packets."
I didn't look at the code yet but I suppose this checkbox is disabled if no
dfilter is active.
Regards,
Olivier
