Ethereal-dev: RE: [Ethereal-dev] The new save as dialog box looks good, but ...
| From: Ulf Lamping
|
| Biot Olivier wrote:
|
| >I would keep the "Save As" widget as is, but refer to the
| active dfilter in
| >the tooltip, as in: "Only consider packets from the packet
| range above which
| >also match the current display filter expression". Should we
| then label the
| >check box with "Restrict the range to the currently
| displayed packets"?
|
| I have tried a lot of variants for the label and the tooltip,
| and wasn't
| satisfied completely with any of the solutions I have found.
| It's maybe a good idea, to currently leave it as it is, and
| try to find
| a good label text in a few days, after using it a few times.
| (and as lot's of mail going around for this topic, there
| doesn't seem to be a simple answer around :-(
See a mail I sent earlier today (I'm however encountering email problems
again so some mails take 12 hours or more to reach the addressee :()
| >The tooltip for manual packet range selection does not show
| an example.
| >
| >
| The tooltip for the radio button not, but the tooltip for the
| text entry
| itself, where the data has to be written in. So I think it's ok here.
|
| >Otherwise I'm really *Very* Fond of the new widget!
| >
| >
| Thanks goes to Dick, as he has done the main work :-)
|
|
| There are some things left to do:
| a.) find a good label (and tooltip) for the "Apply display
| filter" thing
| b.) make this checkbox insensitive, if the display filer
| currently has no effect
| c.) change the labels (and tooltips?) of the radio buttons, if the
| checkbox had changed
| d.) transfer the whole mechanism to the print dialog
| e.) think about the dialog layout
|
| a.) see above
|
| b.) currently the checkbox is always available. It should be only
| sensitive, if a display filter is set *and* if it has some effect
| ("removed" some packets from the current view).
|
| c.) The labels of all the radio buttons should change, if the
| checkbox
| is changed, e.g: "All captured packets (2176 packets)"
| should change in that case to: "All displayed packets (210 packets)",
| and of course all other radios too.
I propose to write something like:
a) "All captured packets (2176 packets, 57 displayed packets)"
OR
b) "All captured packets" and then mention the matches in the label of the
checkbox.
| d.) I can do this, as I have written the current print dialog, but I
| would like to do this, when the save dialog is "ready",
| as there it still work to do, and I don't like changing it
| twice. Maybe
| it's even possible to share GUI code for the save and print dialogs
| (which would be nice), but I have doubts if this will be possible.
|
| e.) the save dialog has become very tall right now. It might
| be a good
| idea, to put the whole range frame to the right of the other widgets.
| As I don't know much of the dialog layout, it's maybe not
| possible, but
| worth a try (and see, if it's looking better).
Great! I'm really happy with the way Ethereal evolves now!
Regards,
Olivier
