Ethereal-dev: Re: [Ethereal-dev] Cann't open capture file (SIP, RTP) (patch)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 17 Dec 2003 12:50:57 -0800

On Dec 17, 2003, at 12:42 PM, Guy Harris wrote:



On Dec 17, 2003, at 3:22 AM, Anders Broman (TN/EAB) wrote:
The problem is that there is an extra octet at the end of packet 195, and no protection in packet-sip. 

Packet 195?  That's an RTP packet.
Presumably you meant "packet 196", and the problem wasn't just the extra octet, the problem was that it had no Content-Type header but did have one byte of packet body. (As it was a BYE request, presumably there's no use in having SDP data in the packet; I don't know whether SIP *requires* a body or not, so I don't know why there's that extra byte in the packet.) The underlying problem wasn't the extra octet, it was the lack of a check for a content type value before calling a subdissector based on that value.