Ethereal-dev: Re: [Ethereal-dev] Cann't open capture file (SIP, RTP) (patch)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 17 Dec 2003 12:42:18 -0800

On Dec 17, 2003, at 3:22 AM, Anders Broman (TN/EAB) wrote:
The problem is that there is an extra octet at the end of packet 195, and no protection in packet-sip. 

Packet 195?  That's an RTP packet.


This is fixed with the included patch.
It also includes some (unfinished) code to include "parameters" to Content-type.
It also removes some code that does something with a media type of multipart/mixed - but it didn't do anything useful, it just set some variables that weren't being used. The right way to handle multipart/mixed is (as I think was mentioned in some other messages) to have a subdissector for it, and pass it the boundary string. 

Checked in, with indentation fixes.
Should the SIP and HTTP dissector share code to parse headers? We should perhaps make common code to handle the headers, with whatever features are needed for both protocols.