Ethereal-dev: Re: [Ethereal-dev] NCP over IP problem, patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: David Eisner <cradle@xxxxxxxxxxxx>
Date: Wed, 11 Jul 2001 22:30:39 -0400 (EDT)
On Wed, 11 Jul 2001, Guy Harris wrote:

> Checked in.
> 
> Another way of doing this might be to pass "commhdr" or "hdr_offset" as
> an extra argument to "dissect_ncp_request()" and "dissect_ncp_reply()",
> and have it refer to fields with offsets that include that argument.
> 
> Also, having both "hdr_offset" and "commhdr" variables in
> "dissect_ncp()" is redundant - perhaps it should just start out setting
> "commhdr" to 0, and then advance that as it dissects NCP-over-{UDP,TCP},
> or use "hdr_offset" instead of "commhdr" and remove "commhdr".
> 

Thanks.  You're probably right.  I'm not too familiar with the
code, so I wanted to make the patch as small as possible.

-David

-----------------------------------------------------
David Eisner            | E-mail: cradle@xxxxxxxxxxx |
CALCE EPSC              | Phone:  301-405-5341       |
University of Maryland  | Fax:    301-314-9269       |
-----------------------------------------------------