Ethereal-dev: Re: [Ethereal-dev] NCP over IP problem, patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 11 Jul 2001 18:50:45 -0700 (PDT)
> I'm attaching a patch which fixes the problem by passing to the reply
> and request dissectors a subset of the tvbuff.

Checked in.

Another way of doing this might be to pass "commhdr" or "hdr_offset" as
an extra argument to "dissect_ncp_request()" and "dissect_ncp_reply()",
and have it refer to fields with offsets that include that argument.

Also, having both "hdr_offset" and "commhdr" variables in
"dissect_ncp()" is redundant - perhaps it should just start out setting
"commhdr" to 0, and then advance that as it dissects NCP-over-{UDP,TCP},
or use "hdr_offset" instead of "commhdr" and remove "commhdr".