On 29/12/19 21:16, João Valverde wrote:
On 29/12/19 20:46, Roland Knall
wrote:
The way here would be to push your patch to
gerrit. iLBC seems to be distributed (at least the codec as
part of the WebRTC project) with a BSD-Style license, so
integration should be doable. Please also check, beside
tools/debian-setup.sh there are scripts in there for other
Linux distributions as well, which have to be adapted, as well
as the before mentioned macOS-brew script.
This doesn't seem to be available in vanilla Debian/Ubuntu (only
deb-multimedia.org) so I think you are out of luck there, unless
you can find a Debian maintainer interested in adopting this
library.
Out of luck for Ubuntu/Debian users.... don't interpret that as a
blocker.
I'm assuming the code won't build with the RHEL/Fedora 1.1.1 package
too, is that correct?
On 29/12/19 13:46, Jiří Novák wrote:
> Hi,
>
>> For Ubuntu there is tools/debian-setup.sh that
installs optional
>> packages (as this).
>> I suggest you to test your change at least on this
platform since it's
>> the most common.
> OK. I will try.
>
>> Did you make your change compilable without that
library? You need some
>> preprocessor ifdefs for that.
> I'm familiar with optional compilation with configure
tools, but I'm
> lost in CMake... On the other hand I tested it and it
is possible to
> compile it without library - CMake detects it is not
there and do not
> compile the code. Therefore it looks I wrote it
correctly.
>
> BTW I have no idea where to get iLBC library for
Windows and Mac. The
> library is open source therefore we can try to compile
it, but I don't
> know how to incorporate this step/procedure to build of
wireshark.
>
> Redhat like systems use version 1.1.1 from 2012 but
many other platforms
> use latest 2.0.2 from 2014.
>
>> If you push your change as WIP you can add me as
reviewer: I have a
>> bunch of builders for many platforms. I can help
you at least to compile
>> it on as many as possible.
> OK, thank you for offer. I'm waiting for accepting a
few changes it
> depends on and then I will push it.
>
I think it would be helpful to push it anyway (your call).
It will speed
up the review of the pending patches and make it easier for
us to help.
Marking it [WIP] or [DONOTCOMMIT] is a good idea in case it
doesn't show
a merge conflict (so it doesn't get merged ahead of the
dependencies).
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
