Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (developme
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx>
Date: Mon, 28 Mar 2016 16:38:49 +0100


On 28-03-2016 16:30, Joerg Mayer wrote:

On Mon, Mar 28, 2016 at 04:04:48PM +0100, João Valverde wrote:

The variable is set but not used. Nothing strange about the warning.


Pascal seems to have understood what I meant: The variable is indeed unused
and the compiler should complain about this no matter whether it is declared
unused or not.
I really don't understand why you seem to be saying the compiler should complain about a variable that was declared unused (before your change). 


Anyway: From my analysis it seems there was a bug hidden somewhere (the struct
elements were not added) either in epan/wslua/make-taps.pl or packet-bacapp.[hc]
that was now exposed by actually receiving the warning and Pascal is working on
a fix.


Yes, apparently a bug was exposed and caught, this is a very nice outcome.