Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] buildbot failure in Wireshark (developme
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Mon, 28 Mar 2016 17:08:41 +0200
Hi Jörg,

2016-03-28 16:51 GMT+02:00 Joerg Mayer <jmayer@xxxxxxxxx>:
On Mon, Mar 28, 2016 at 02:26:41PM +0000, buildbot-no-reply@xxxxxxxxxxxxx wrote:
> The Buildbot has detected a new failure on builder Ubuntu 14.04 x64 while building wireshark. Full details are available at:
>     http://buildbot.wireshark.org/wireshark-master/builders/Ubuntu%2014.04%20x64/builds/5897

../../../epan/wslua/taps_wslua.c: In function 'wslua_bacapp_to_table':
../../../epan/wslua/taps_wslua.c:43:93: error: variable 'v' set but not used [-Werror=unused-but-set-variable]
 static void wslua_bacapp_to_table(lua_State* L, const void* p) { const bacapp_info_value_t* v; v = (const bacapp_info_value_t*)p; lua_newtable(L);

> Buildbot URL: http://buildbot.wireshark.org/wireshark-master/
>
> Buildslave for this Build: ubuntu-14.04-x64
>
> Build Reason: The SingleBranchScheduler scheduler named 'Gerrit' triggered this build
> Build Source Stamp: [branch master] 7e5dae90d65ed062f2d01c63174cc1c94850a19a
> Blamelist: Jörg Mayer <jmayer@xxxxxxxxx>
>
> BUILD FAILED: failed make distcheck

OK, this is strange: I changed epan/wslua/make-taps.pl to not declare v as _U_ (which
is obviously isn't: it's used in the next statement) and now we get a "set but not used"
warning but not before? Btw, on my Clang (XCode) system I do not get this warning/error.
Ideas what is going on here (compiler bug?)?

v is set, but does not seem to be used (this what gcc is complaining about). Presumably marking the variable as unused was hiding this warning.
It appears that make-taps.pl was not working as expected with packet-bacapp.h due tio the use of a const. I'm about to push a fix for this.

Pascal.