Agreed. Another option would be to register the payload type if the preference is in the range of [96-127]. The same concerns the RTP events (RFC 4733, RFC 2833).
From: Anders Broman <a.broman@xxxxxxxxxxxx>
To: Arsen Chaloyan <achaloyan@xxxxxxxxx>; Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Friday, March 9, 2012 11:58 AM
Subject: Re:
[Wireshark-dev] RTP Payload Type for MIDI
Arsen Chaloyan skrev 2012-03-09 19:54:
Hi,
Building Wireshark from the latest source, I've noticed a
small issue related to the dissection of RTP packets.
A generic RTP PCMU (pt=0) packet is decoded as a malformed
RTP-MIDI packet. The problem is the default payload type
assigned to the RTP-MIDI packets is set to 0, which is just an
oversight, I believe. It should be in the range of dynamic
payload types such as 96-127. Changing that value from the
Preferences helps. However, you may want to change the default
value in the code too.
Index: packet-rtp-midi.c
===================================================================
--- packet-rtp-midi.c (revision 41439)
+++ packet-rtp-midi.c (working copy)
@@ -2897,7 +2897,7 @@
static gint ett_rtp_midi_sysex_common_tune_note = -1;
-static guint rtp_midi_payload_type_value = 0;
+static guint rtp_midi_payload_type_value = 96;
Hope this helps,
Arsen
Hi,
I think the solution should be that if the preference is set to zero
the payload type should not be registered.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
