Wireshark-dev: [Wireshark-dev] RTP Payload Type for MIDI
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Arsen Chaloyan <achaloyan@xxxxxxxxx>
Date: Fri, 9 Mar 2012 10:54:41 -0800 (PST)
Hi,

Building Wireshark from the latest source, I've noticed a small issue related to the dissection of RTP packets.

A generic RTP PCMU (pt=0) packet is decoded as a malformed RTP-MIDI packet. The problem is the default payload type assigned to the RTP-MIDI packets is set to 0, which is just an oversight, I believe. It should be in the range of dynamic payload types such as 96-127. Changing that value from the Preferences helps. However, you may want to change the default value in the code too.

Index: packet-rtp-midi.c
===================================================================
--- packet-rtp-midi.c    (revision 41439)
+++ packet-rtp-midi.c    (working copy)
@@ -2897,7 +2897,7 @@
 static gint ett_rtp_midi_sysex_common_tune_note        = -1;
 
 
-static guint rtp_midi_payload_type_value    = 0;
+static guint rtp_midi_payload_type_value    = 96;

Hope this helps,
Arsen