Wireshark-dev: Re: [Wireshark-dev] deprecating check_col()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Date: Fri, 22 Oct 2010 15:49:47 +0200
On Fri, Oct 22, 2010 at 3:44 PM, Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> wrote:
> Should we discuss the concept of removing all check_col()'s again? In
> looking at the PPP dissector, for example, it seems there may be a fair
> amount of work saved by keeping them.

My intention behind putting this check in all col_* functions was that
you do not _need_ to use check_col(), but may use it if something
needs to be calculated before put in a column.  So a case-by-case
basis sounds right to me.


-- 
Stig Bjørlykke