Wireshark-dev: Re: [Wireshark-dev] deprecating check_col()
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Fri, 22 Oct 2010 09:44:48 -0400
bugzilla-daemon@xxxxxxxxxxxxx wrote:

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5325

--- Comment #6 from Jeff Morriss <jeff.morriss.ws@xxxxxxxxx> 2010-10-22 06:31:48 PDT ---
(In reply to comment #5)

Check col is deprecated and should be removed.


Well, you know, I don't know.  In this dissector it's protecting not only the
col_*() calls but also some val_to_str()'s and other non-trivial amounts of
work.
Should we discuss the concept of removing all check_col()'s again? In looking at the PPP dissector, for example, it seems there may be a fair amount of work saved by keeping them. 

Maybe it should be on a case-by-case basis?