Wireshark-commits: [Wireshark-commits] master 9eddbda: Don't give a zero-length FT_STRINGZ a specia
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2020 08:50:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9eddbdafa975f9c3bafec9e1d2f5f52469a10a28
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9eddbda by Guy Harris (gharris@xxxxxxxxx):

    Don't give a zero-length FT_STRINGZ a special value.
    
    It's arguably an error, as an FT_STRINGZ requires at least one character
    position for the terminating NUL, but the way to handle that is to give
    it a string value of an empty string and add an expert info indicating
    that the terminating NUL is missing.  (The same should be done for
    FT_STRINGZ fields with a specified non-zero length that don't have a NUL
    in the last character position.)
    
    Change-Id: Ie702bf44db36310f0f6e2625a3a64e6424167546
    Reviewed-on: https://code.wireshark.org/review/38136
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  3e9bf7d   MQ: use FT_STRING, not FT_STRINGZ, for strings.
     add  9eddbda   Don't give a zero-length FT_STRINGZ a special value.


Summary of changes:
 epan/proto.c | 2 --
 1 file changed, 2 deletions(-)