Wireshark-commits: [Wireshark-commits] master 3e9bf7d: MQ: use FT_STRING, not FT_STRINGZ, for strin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Aug 2020 07:43:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3e9bf7d7cb568281e480a5ac40ba075321b7e585
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3e9bf7d by Guy Harris (gharris@xxxxxxxxx):

    MQ: use FT_STRING, not FT_STRINGZ, for strings.
    
    The documentation mentioned looks more like API/ABI documentation than
    "data on the wire" documentation, but the strings all look like counted
    strings, with no trwminating NUL.  Use FT_STRING, not FT_STRINGZ.
    
    Add a URL for the MQ PCF documentation and replace no-longer-working
    URLs for the MQ documentation with a working URL.
    
    Change-Id: Id656a3e6cd75bff34d1a5a650229b4ba749ef365
    Reviewed-on: https://code.wireshark.org/review/38134
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  9c1a55a   RPC: partially dissect GSS NFS truncated packets
     add  3e9bf7d   MQ: use FT_STRING, not FT_STRINGZ, for strings.


Summary of changes:
 epan/dissectors/packet-mq-pcf.c |  13 ++-
 epan/dissectors/packet-mq.c     | 241 ++++++++++++++++++++--------------------
 2 files changed, 129 insertions(+), 125 deletions(-)