Wireshark-commits: [Wireshark-commits] master d3c4dfa: wsutil: use ws_in4_addr in tvb_get_ipv4_addr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Apr 2020 08:31:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3c4dfa9eed79d100f039f7042577cadb8fcad06
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d3c4dfa by Dario Lombardo (lomato@xxxxxxxxx):

    wsutil: use ws_in4_addr in tvb_get_ipv4_addr_with_prefix_len.
    
    Instead of guint8* the used type looks more precise. Moreover there
    is no need to use local unions in the dissectors to switch between
    the actual address and address bytes.
    
    bgp, eigrp and isis-lsp dissectors have been updated accordingly.
    
    Change-Id: I7785fe4c12913a09bd31cd6ef26e53027646d35c
    Reviewed-on: https://code.wireshark.org/review/36836
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  ab52c76   Bluetooth: Complete Additional Controller Advertising Data dissecting
     add  d3c4dfa   wsutil: use ws_in4_addr in tvb_get_ipv4_addr_with_prefix_len.


Summary of changes:
 epan/addr_and_mask.c              |  6 ++--
 epan/addr_and_mask.h              |  5 +++-
 epan/dissectors/packet-bgp.c      | 58 ++++++++++++++++-----------------------
 epan/dissectors/packet-eigrp.c    | 11 +++-----
 epan/dissectors/packet-isis-lsp.c | 37 ++++++++++++-------------
 5 files changed, 51 insertions(+), 66 deletions(-)