Wireshark-commits: [Wireshark-commits] master ab52c76: Bluetooth: Complete Additional Controller Ad
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 14 Apr 2020 06:23:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ab52c76cb67169ef83750333476cff69fc0d406a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ab52c76 by Joakim Andersson (joakim.andersson@xxxxxxxxxxxxx):

    Bluetooth: Complete Additional Controller Advertising Data dissecting
    
    Complete Additional Controller Advertising Data dissecting, this was just
    reported as advertising data in the extended header. Put it under a new tree
    for ACAD info in the extended header.
    Also fix the wrong length field used for the length of the ACAD field.
    
    In addition put the scan response data under it's own scan response, similar
    to SCAN_RSP handling. We can only do this if the context has given us the
    information that this is the aux scan response data.
    
    Remove an accidental addition used for debugging, and an empty if-statement for
    a reserved flag.
    
    Change-Id: I7f0ad74b3e30ffecade59b6d0c5965bfc634531e
    Signed-off-by: Joakim Andersson <joakim.andersson@xxxxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36835
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c2d67c0   wiretap: don't use memset where possible.
     add  ab52c76   Bluetooth: Complete Additional Controller Advertising Data dissecting


Summary of changes:
 epan/dissectors/packet-btle.c | 27 ++++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)