Wireshark-commits: [Wireshark-commits] master 02ef284: CMake: fix another Windows specific warning
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 20:41:38 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=02ef284140f73fc865e778936cdfa1556a32dfe6
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

02ef284 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    CMake: fix another Windows specific warning reported by CMake 3.17
    
    Newer version of CMake complains with warnings like the one below:
    
    The package name passed to `find_package_handle_standard_args` (POWERSHELL)
    does not match the name of the calling package (PowerShell).  This can lead
    to problems in calling code that expects `find_package` result variables
    (e.g., `_FOUND`) to follow a certain pattern.
    
    Change the capitalization of the variables to match the filename.
    
    Change-Id: I5bd763add92e9e279f8e28f31576acb5b9ea7776
    Reviewed-on: https://code.wireshark.org/review/36833
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  514706b   GSM/SMS: clarify 'no error' values of TP-Status IE
     add  02ef284   CMake: fix another Windows specific warning reported by CMake 3.17


Summary of changes:
 cmake/modules/FindPowerShell.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)