Wireshark-commits: [Wireshark-commits] master 514706b: GSM/SMS: clarify 'no error' values of TP-Sta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 19:32:16 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=514706b1f87c0a1a45eff4d91d31faec6a9d9323
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

514706b by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM/SMS: clarify 'no error' values of TP-Status IE
    
    In case of successfull delivery, TP-Status IE looks as follows:
    
      TP-Status
          0... .... = Definition of bits 0-6: as follows
          .00. .... = Error: Short message transaction completed (0)
          ...0 0000 = Reason: Short message received by the SME (0)
    
    in particular, "Error: Short message transaction completed" looks
    confusing. Let's make it a bit cleaner:
    
      TP-Status
          0... .... = Definition of bits 0-6: as follows
          .00. .... = Error: No error, short message transaction completed (0)
          ...0 0000 = Reason: Short message received by the SME (0)
    
    Change-Id: I95830877c1ff2f45e3c68a40febcf357abda597d
    Reviewed-on: https://code.wireshark.org/review/36829
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  fd19f39   GSM/SMS: decouple error and reason fields in TP-Status IE
     add  514706b   GSM/SMS: clarify 'no error' values of TP-Status IE


Summary of changes:
 epan/dissectors/packet-gsm_sms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)